https://bugzilla.redhat.com/show_bug.cgi?id=2437502



--- Comment #77 from Nicola Taibi <[email protected]> ---
C/C++:
[x]: Package does not contain kernel modules.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Package does not contain any libtool archives (.la)
[x]: Package contains no static executables.
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
     Note: Using prebuilt packages
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "GNU General Public License v3.0 or later", "Unknown or
     generated", "Creative Commons Attribution 4.0 and/or GNU General
     Public License, Version 3", "GNU General Public License, Version 3".
     59 files have unknown license. Detailed output of licensecheck in
     /var/lib/copr-rpmbuild/results/spacegl/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries or specifies bundled libraries
     with Provides: bundled(<libname>) if unbundling is not possible.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 310665 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
     desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[x]: Reviewer should test that the package builds in mock.
[x]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in spacegl-
     data
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: No rpmlint messages.
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.


Rpmlint
-------
Checking: spacegl-2026.02.09-16.fc45.x86_64.rpm
          spacegl-data-2026.02.09-16.fc45.noarch.rpm
          spacegl-2026.02.09-16.fc45.src.rpm
============================ rpmlint session starts
============================
rpmlint: 2.8.0
configuration:
    /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpm90im00b')]
checks: 32, packages: 3

spacegl.spec: W: specfile-warning sh: warning: setlocale: LC_ALL: cannot change
locale (en_US.UTF-8): No such file or directory
spacegl.spec: W: specfile-warning sh: warning: setlocale: LC_ALL: cannot change
locale (en_US.UTF-8): No such file or directory
spacegl.spec: W: specfile-warning sh: warning: setlocale: LC_ALL: cannot change
locale (en_US.UTF-8): No such file or directory
spacegl.x86_64: W: no-manual-page-for-binary spacegl-client
spacegl.x86_64: W: no-manual-page-for-binary spacegl-server
spacegl.x86_64: W: no-manual-page-for-binary spacegl_3dview
spacegl.x86_64: W: no-manual-page-for-binary spacegl_client
spacegl.x86_64: W: no-manual-page-for-binary spacegl_server
spacegl.x86_64: W: no-manual-page-for-binary spacegl_viewer
spacegl-data.noarch: W: no-documentation
spacegl.spec:105: W: macro-in-%changelog %{rel}
 3 packages and 0 specfiles checked; 0 errors, 11 warnings, 14 filtered, 0
badness; has taken 3.6 s 




Rpmlint (debuginfo)
-------------------
Checking: spacegl-debuginfo-2026.02.09-16.fc45.x86_64.rpm
============================ rpmlint session starts
============================
rpmlint: 2.8.0
configuration:
    /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmppfyzd2ms')]
checks: 32, packages: 1

 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 16 filtered, 0
badness; has taken 0.2 s 





Rpmlint (installed packages)
----------------------------
(none): E: there is no installed rpm "spacegl".
(none): E: there is no installed rpm "spacegl-debuginfo".
(none): E: there is no installed rpm "spacegl-data".
There are no files to process nor additional arguments.
Nothing to do, aborting.
============================ rpmlint session starts
============================
rpmlint: 2.8.0
configuration:
    /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 3

 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0
badness; has taken 0.0 s 



Source checksums
----------------
https://github.com/nicolataibi/spacegl/archive/refs/tags/2026.02.09-16.tar.gz :
  CHECKSUM(SHA256) this package     :
446ceb0057cd5391f70610a457d847a3a760f0f2a0dcbb2c0743c5928b4aec9e
  CHECKSUM(SHA256) upstream package :
446ceb0057cd5391f70610a457d847a3a760f0f2a0dcbb2c0743c5928b4aec9e


Requires
--------
spacegl (rpmlib, GLIBC filtered):
    /usr/bin/bash
    freeglut
    glew
    libGL.so.1()(64bit)
    libGLEW.so.2.2()(64bit)
    libGLU.so.1()(64bit)
    libc.so.6()(64bit)
    libcrypto.so.3()(64bit)
    libcrypto.so.3(OPENSSL_3.0.0)(64bit)
    libglut.so.3()(64bit)
    libm.so.6()(64bit)
    mesa-libGL
    mesa-libGLU
    openssl
    rtld(GNU_HASH)
    spacegl-data

spacegl-data (rpmlib, GLIBC filtered):
    spacegl



Provides
--------
spacegl:
    application()
    application(spacegl.desktop)
    spacegl
    spacegl(x86-64)

spacegl-data:
    spacegl-data



Generated by fedora-review 0.11.0 (05c5b26) last change: 2025-11-29
Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name
spacegl --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: R, SugarActivity, PHP, fonts, Ocaml, Java, Python, Haskell,
Perl
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH

- F7 - Anisotropic Filtering: Improves the sharpness of slanted surfaces
(cycles through 1x, 2x, 4x, 8x, 16x).
- F8 - Starfield Density: Changes the number of background stars (from 1,000 to
8,000). Useful for making space feel denser or reducing the load on the GPU.
- Multi-Tube Independent Logic: The system now supports firing up to four
torpedoes in rapid succession.
- Cyclic Reload HUD: The [L] (Loading) status is now correctly displayed for
each individual tube.
- Boundary Enforcement: Torpedoes now explode immediately upon reaching
quadrant boundaries.
- Universal Visibility: Torpedoes from all players are now rendered in
everyone's 3D view (Object Type 28).
- Optimized HUD: Personal HUD indicators accurately track your own torpedoes,
while the 3D view displays all tactical ordnance without cluttering the screen
with unnecessary labels.
- Quadrants: 40x40x40 (64,000 quadrants).Sectors (Units): 40x40x40 per
quadrant.Absolute Coordinate System: Migrated from 0-400 to 0.0-1600.0.
- Vastness: The galaxy is now 64 times larger in terms of absolute unit volume,
ensuring superior fluidity during high-speed movement.
- All navigation commands (nav, imp, apr) and calculators (cal, ical) now
operate with hundredth-degree precision (%.2f).
- Short-Range Sensors (srs) and status reports (sta) now display coordinates
and distances with two decimal places.
- Hyperdrive Recalibration: Warp Factor 9.9 traverses the galaxy's diagonal
($\approx 2771$ units) in 40 real-world seconds.
- HUD ETA: Added a yellow field in the 3D viewer that displays the Estimated
Time of Arrival in seconds; this is only visible when a destination is set.
- Tactical Cube: The quadrant frame has been scaled to $40 \times 40 \times
40$.Tactical Grid: Now covers the entire sector volume with reference lines
every 10 units.
- Precision has been increased to "millimeter" level, with a stopping tolerance
of 0.01 units (ten times more precise). This is critical for docking and
boarding maneuvers.
- Full HD (**1920x1080**) support via `TACTICAL_CUBE_W/H` macros.

The game is now feature-complete and stable (~99%). Ready for final technical
review.

Release 16.


With kind regards, Nick

Spec URL:
https://download.copr.fedorainfracloud.org/results/ntaibi/space-gl/fedora-rawhide-x86_64/10153706-spacegl/spacegl.spec

SRPM URL:
https://download.copr.fedorainfracloud.org/results/ntaibi/space-gl/fedora-rawhide-x86_64/10153706-spacegl/spacegl-2026.02.09-16.fc45.src.rpm


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2437502

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202437502%23c77

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://forge.fedoraproject.org/infra/tickets/issues/new

Reply via email to