https://bugzilla.redhat.com/show_bug.cgi?id=2417806
--- Comment #22 from Peter Oliver <[email protected]> --- Many of the tests are still being skipping for missing dependencies that we have in Fedora. We could run more tests by BuildRequiring /usr/bin/cabextract, /usr/bin/7za, /usr/bin/bsdtar, etc. Some of the tests are skipped because archive_color and vimcolor could not be found. This package provides them itself, so perhaps %{bindir} needs adding to $PATH before running the tests? Instead of "%{_prefix}/libexec", you should write "%{_libexecdir}". I still think it would be better to automatically modify the LESSOPEN environment variable only if it is not already set. See the less package for examples of the shell code that can do this: - https://src.fedoraproject.org/rpms/less/blob/rawhide/f/less.csh - https://src.fedoraproject.org/rpms/less/blob/rawhide/f/less.sh I think the files you drop into /etc/profile.d to do this should have "lesspipe" in their names, since that's the name of the package that they belong to, and the name of the tool they are acting for. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2417806 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202417806%23c22 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
