https://bugzilla.redhat.com/show_bug.cgi?id=2418265



--- Comment #5 from Dominik 'Rathann' Mierzejewski <[email protected]> ---
(In reply to Petr Pisar from comment #3)
> TODO: Build-require "coreutils" for %{_fixperms} macro
> (perl-Chemistry-Ring.spec:46).
> TODO: Constrain "perl(Chemistry::Mol)" dependency with ">= 0.24"
> (META.json:24).
> TODO: Constrain "perl(Statistics::Regression)" dependency with ">= 0.15"
> (META.json:25).
> 
> FIX: Build-require "perl(strict)" (Makefile.PL:2).
> FIX: Build-require "perl(warnings)" (Makefile.PL:3).
> FIX: Build-require "perl(base)" (lib/Chemistry/Ring.pm:53).
> FIX: Build-require "perl(Exporter)" (lib/Chemistry/Ring.pm:53).
> FIX: Build-require "perl(Scalar::Util)" (lib/Chemistry/Ring.pm:54).
> 
> FIX: Remove the "find %{buildroot} -type f -name '*.bs' -empty -delete" line
> at perl-Chemistry-Ring.spec:45. It's not needed for noarch Perl packages.
> 
> FIX: Package "Changes" file as a documenation.

All fixed, thanks for the review.

> FATAL: This package build-require "perl(Chemistry::File::SMILES)" which is
> not provided by any package in Fedora. Please package that first.

Up for review under bug 2417812.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2418265

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202418265%23c5

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://forge.fedoraproject.org/infra/tickets/issues/new

Reply via email to