https://bugzilla.redhat.com/show_bug.cgi?id=2418265

Petr Pisar <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #14 from Petr Pisar <[email protected]> ---
$ rpmlint perl-Chemistry-Ring.spec
../SRPMS/perl-Chemistry-Ring-0.21-1.fc45.src.rpm
../RPMS/noarch/perl-Chemistry-Ring-0.21-1.fc45.noarch.rpm 
======================================== rpmlint session starts
=======================================
rpmlint: 2.9.0
configuration:
    /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 3

perl-Chemistry-Ring.noarch: E: spelling-error ('centroid', '%description -l
en_US centroid -> centric')
perl-Chemistry-Ring.noarch: E: spelling-error ('aromaticity', '%description -l
en_US aromaticity -> aromatically, aromatic')
perl-Chemistry-Ring.src: E: spelling-error ('centroid', '%description -l en_US
centroid -> centric')
perl-Chemistry-Ring.src: E: spelling-error ('aromaticity', '%description -l
en_US aromaticity -> aromatically, aromatic')
=== 2 packages and 1 specfiles checked; 4 errors, 0 warnings, 6 filtered, 4
badness; has taken 0.5 s ==
rpmlint is Ok.

$ rpm -q --requires -p
../RPMS/noarch/perl-Chemistry-Ring-0.21-1.fc45.noarch.rpm | sort -f | uniq -c
      1 perl(base)
      1 perl(Chemistry::Mol)
      1 perl(Chemistry::Mol) >= 0.24
      1 perl(Chemistry::Ring)
      1 perl(Exporter)
      1 perl(Math::VectorReal)
      1 perl(Scalar::Util)
      1 perl(Statistics::Regression)
      1 perl(Statistics::Regression) >= 0.15
      1 perl(strict)
      1 perl(warnings)
      1 perl-libs
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsZstd) <= 5.4.18-1
TODO: Remove the underspecified unversioned run-time dependencies on
"perl(Chemistry::Mol)" and "perl(Statistics::Regression)" to minimize the set
of dependencies. How to do is somewhat documented at
<https://docs.fedoraproject.org/en-US/packaging-guidelines/AutoProvidesAndRequiresFiltering/>,
but this example
<https://src.fedoraproject.org/rpms/perl-PDF-Builder/blob/rawhide/f/perl-PDF-Builder.spec#_119>
is probably easier to understand.

$ resolvedeps rawhide ../RPMS/noarch/perl-Chemistry-Ring-0.21-1.fc45.noarch.rpm 
Binary dependencies are resolvable. Ok.

The package builds in Rawhide
(https://koji.fedoraproject.org/koji/taskinfo?taskID=146481756). Ok.

This package is in line with Fedora and Perl packaging guidelines.
Please consider fixing the TODO item before building this package.
This package is APPROVED.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2418265

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202418265%23c14

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://forge.fedoraproject.org/infra/tickets/issues/new

Reply via email to