https://bugzilla.redhat.com/show_bug.cgi?id=2418265
--- Comment #12 from Petr Pisar <[email protected]> --- Thanks for the update. TODO: Remove OPTIMIZE argument from perl Makefile.PL program. It's not needed for noarch packages. FIX: The perl_bootstrap macro is a Perl ecosystem-wide macro which enables building all Perl packages from scratch and it's supposed to be used differently. For an example look at <https://src.fedoraproject.org/rpms/perl-IO-Compress/raw/rawhide/f/perl-IO-Compress.spec>. Correct usage for your package is this: --- perl-Chemistry-Ring.spec 2026-06-09 18:43:03.000000000 +0200 +++ perl-Chemistry-Ring.spec.new 2026-06-10 09:13:22.423388993 +0200 @@ -1,5 +1,5 @@ %bcond check 1 -%bcond perl_bootstrap 1 +%define perl_bootstrap 1 Name: perl-Chemistry-Ring Version: 0.21 @@ -19,7 +19,7 @@ BuildRequires: perl(strict) BuildRequires: perl(warnings) %if %{with check} -%if %{without perl_bootstrap} +%if !%{defined perl_bootstrap} BuildRequires: perl(Chemistry::File::SMILES) %endif BuildRequires: perl(Chemistry::Mol) >= 0.24 After getting Chemistry::File::SMILES into Fedora, you delete the "%define perl_bootstrap 1" line from this spec file. That's all. All tests pass. Ok. $ rpmlint perl-Chemistry-Ring.spec ../SRPMS/perl-Chemistry-Ring-0.21-1.fc45.src.rpm ../RPMS/noarch/perl-Chemistry-Ring-0.21-1.fc45.noarch.rpm ======================================== rpmlint session starts ======================================= rpmlint: 2.9.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3 perl-Chemistry-Ring.noarch: E: spelling-error ('centroid', '%description -l en_US centroid -> centric') perl-Chemistry-Ring.noarch: E: spelling-error ('aromaticity', '%description -l en_US aromaticity -> aromatically, aromatic') perl-Chemistry-Ring.src: E: spelling-error ('centroid', '%description -l en_US centroid -> centric') perl-Chemistry-Ring.src: E: spelling-error ('aromaticity', '%description -l en_US aromaticity -> aromatically, aromatic') === 2 packages and 1 specfiles checked; 4 errors, 0 warnings, 6 filtered, 4 badness; has taken 0.5 s == rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-Chemistry-Ring-0.21-1.fc45.noarch.rpm drwxr-xr-x 2 root root 0 Jun 10 02:00 /usr/share/doc/perl-Chemistry-Ring -rw-r--r-- 1 root root 1252 Dec 16 2022 /usr/share/doc/perl-Chemistry-Ring/Changes -rw-r--r-- 1 root root 1359 Dec 16 2022 /usr/share/doc/perl-Chemistry-Ring/README -rw-r--r-- 1 root root 2313 Jun 10 02:00 /usr/share/man/man3/Chemistry::Ring.3pm.gz -rw-r--r-- 1 root root 2617 Jun 10 02:00 /usr/share/man/man3/Chemistry::Ring::Find.3pm.gz drwxr-xr-x 2 root root 0 Jun 10 02:00 /usr/share/perl5/vendor_perl/Chemistry drwxr-xr-x 2 root root 0 Jun 10 02:00 /usr/share/perl5/vendor_perl/Chemistry/Ring -rw-r--r-- 1 root root 6153 Dec 16 2022 /usr/share/perl5/vendor_perl/Chemistry/Ring.pm -rw-r--r-- 1 root root 10644 Dec 16 2022 /usr/share/perl5/vendor_perl/Chemistry/Ring/Find.pm File permissions and layout are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Chemistry-Ring-0.21-1.fc45.noarch.rpm | sort -f | uniq -c 1 perl(base) 1 perl(Chemistry::Mol) 1 perl(Chemistry::Ring) 1 perl(Math::VectorReal) 1 perl(Scalar::Util) 1 perl(Statistics::Regression) 1 perl(strict) 1 perl(warnings) 1 perl-libs 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 TODO: Constrain "perl(Chemistry::Mol)" run-time dependency with ">= 0.24" (META.json:24). TODO: Constrain "perl(Statistics::Regression)" run-time dependency with ">= 0.15" (META.json:25). FIX: Run-require "perl(Exporter)" (lib/Chemistry/Ring.pm:53). $ rpm -q --provides -p ../RPMS/noarch/perl-Chemistry-Ring-0.21-1.fc45.noarch.rpm | sort -f | uniq -c 1 perl(Chemistry::Ring) = 0.21 1 perl(Chemistry::Ring::Find) = 0.21 1 perl-Chemistry-Ring = 0.21-1.fc45 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-Chemistry-Ring-0.21-1.fc45.noarch.rpm Binary dependencies are resolvable. Ok. The package builds in F45 (https://koji.fedoraproject.org/koji/taskinfo?taskID=146468355). Ok. Otherwise, the package is in line with Fedora and Perl packaging guidelines. Please correct the FIX items, consider fixing the TODO items, and provide a new spec file. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2418265 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202418265%23c12 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
