https://bugzilla.redhat.com/show_bug.cgi?id=2491207
Zbigniew Jędrzejewski-Szmek <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #2 from Zbigniew Jędrzejewski-Szmek <[email protected]> --- > BuildRequires: python3dist(pytest) > BuildRequires: python3dist(oath) The right column could be indented by one line more to match the rest of the file. Hmm, should the main package be called 'python3-pynitrokey' or just 'nitropy'? I guess the existing name is better. But please add 'Provides: nitropy' so that people can easily install using the executable name. It'd also be nice to extend the %description for the binary package with some hints what nitropy is good for. Something that'd tell people what this package is useful for, and also make it easier if they're trying to deal with TOTP and such. > Requires: /usr/lib/udev/rules.d/41-nitrokey.rules This is not allowed (and it also doesn't work with dnf5): https://docs.fedoraproject.org/en-US/packaging-guidelines/#_file_and_directory_dependencies: > Packages MAY include such dependencies for paths inside one of the following > directories: > /usr/bin > /etc What was the error that rpmlint gave? Looks reasonable in general. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2491207 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202491207%23c2 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
