https://bugzilla.redhat.com/show_bug.cgi?id=2491207

Zbigniew JÄ™drzejewski-Szmek <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review+
           Assignee|[email protected]    |[email protected]
             Status|NEW                         |POST



--- Comment #6 from Zbigniew JÄ™drzejewski-Szmek <[email protected]> ---
> python3-pynitrokey.noarch: E: explicit-lib-dependency libnitrokey.
The rpmlint error is meant to prevent manual dependencies being added for
shared libraries, but here the dependency is on the package for other files
that are in it. So please just use 'Requires: libnitrokey'.
(rpmlint is often wrong. Don't take it what is says as gospel.)

+ package name is OK
+ latest version
+ license is specified correctly (MIT + Apache 2.0)
+ license is acceptable for Fedora
+ builds and installs OK
+ R/BR/P appear correct (modulo the issue discussed above).

Standard pyproject packaging is used, nothing out of the ordinary.

The udev rules provided by libnitrokey look reasonable too.

Package is APPROVED. Please fix the libnitrokey dep when importing.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2491207

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202491207%23c6

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://forge.fedoraproject.org/infra/tickets/issues/new

Reply via email to