https://bugzilla.redhat.com/show_bug.cgi?id=2491207



--- Comment #3 from Daniel Milnes <[email protected]> ---
> The right column could be indented by one line more to match the rest of the 
> file.
Done

> But please add 'Provides: nitropy' so that people can easily install using 
> the executable name.
Done

> It'd also be nice to extend the %description for the binary package with
> some hints what nitropy is good for. Something that'd tell people what
> this package is useful for, and also make it easier if they're trying to
> deal with TOTP and such.
Expanded it a bit

> This is not allowed (and it also doesn't work with dnf5):
Oh interesting. Explains some errors I was having on a non-Fedora project...

> What was the error that rpmlint gave?
python3-pynitrokey.noarch: E: explicit-lib-dependency libnitrokey.
libnitrokey doesn't have a `pkgconfig(` provides or similar that could be used
instead.

Spec URL:
https://download.copr.fedorainfracloud.org/results/thebeanogamer/python3-pynitrokey/srpm-builds/10622651/python-pynitrokey.spec
SRPM URL:
https://download.copr.fedorainfracloud.org/results/thebeanogamer/python3-pynitrokey/srpm-builds/10622651/python-pynitrokey-0.12.3-1.src.rpm


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2491207

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202491207%23c3

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://forge.fedoraproject.org/infra/tickets/issues/new

Reply via email to