https://bugzilla.redhat.com/show_bug.cgi?id=2497706
Miro Hrončok <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] Flags| |fedora-review? Assignee|[email protected] |[email protected] Status|NEW |ASSIGNED --- Comment #3 from Miro Hrončok <[email protected]> --- I am willing to work with Simone and eventually get them sponsored. spec sanity: The linked spec file is rpmautospec-processed. it is better to link ot a spec file that hasn't been processed by rpmautospec (e.g. it has plain %autochangelog and no ## START: Set by rpmautospec section). > %pytest --override-ini addopts= Perhaps document in a comment why those options are used. I suppose it is to drop: [tool.pytest.ini_options] addopts = "--cov --cov-report=term-missing" But it is not obvious without looking at the config. > %license LICENSE Upstream has: license = { file = "LICENSE" } So this should not be needed. Instead, pass -l (--assert-license) to %pyproject_save_files. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2497706 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202497706%23c3 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
