https://bugzilla.redhat.com/show_bug.cgi?id=2497706
Miro Hrončok <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #13 from Miro Hrončok <[email protected]> --- 1. Naming (MUST): Source python-pytokens, binary python3-pytokens -- correct per Python naming guidelines. 2. License (MUST): MIT. LICENSE file contains standard MIT text (copyright Tushar Sadhwani). License: MIT SPDX identifier is correct. License included via %pyproject_save_files -l (verified in .dist-info/licenses/LICENSE). 3. Source URL (MUST): %{pypi_source pytokens} -- SHA256 checksums match upstream. 4. Build success (MUST): Build succeeded on all architectures. All 4 tests pass. 5. BuildRequires (MUST): python3-devel present. python3-pytest for tests. 6. Spec legibility (MUST): Clean, legible, American English. 7. Macros (MUST): Consistent usage (%autosetup, %pyproject_wheel, %pyproject_install, %pyproject_save_files, %pytest, %autorelease, %autochangelog). 8. No bundled libraries (MUST): Pure Python, no bundled code. 9. Directory ownership (MUST): Correct. /usr/lib/python3.15/site-packages owned by python3 -- known fedora-review false positive. 10. File permissions (MUST): Correct. 11. No duplicate files (MUST): Confirmed. 12. UTF-8 filenames (MUST): Confirmed. 13. Dist-info metadata (MUST per Python guidelines): Present. 14. Provides/Requires: Correct (python3dist(pytokens), python3.15dist(pytokens), etc.). Only runtime require is python(abi) = 3.15 (package has no runtime deps). 15. Tests (SHOULD/MUST): %check runs %pytest, 4/4 pass. Coverage skipped cleanly via --override-ini. 16. No deprecated packages (MUST): Confirmed. 17. PyPI parity (SHOULD): Package exists on PyPI. 18. BuildArch: noarch: Correct -- mypyc disabled via PYTOKENS_USE_MYPYC=0. rpmlint - zero-length _mypyc_dummy.py -- Not an issue. Intentional upstream file, a mypyc compilation stub that is empty by design. - spelling-error ('tokenizer') -- Not an issue. "Tokenizer" is a valid English word. Package APPROVED. I'll sponsor you and work with you on python-black update. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2497706 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202497706%23c13 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
