https://bugzilla.redhat.com/show_bug.cgi?id=2497706
--- Comment #6 from Miro Hrončok <[email protected]> --- The spec uses %pyproject_buildrequires -x dev, which pulls in the entire [dev] extra: black, build, mypy, pytest, pytest-cov, setuptools, tox, twine, wheel. Per the Python packaging guidelines, linters like black and mypy SHOULD NOT be run in %check, and tools like build, twine, and tox are not needed. Since the spec uses %pytest (not %tox), only pytest is actually needed. The spec should ideally use just BuildRequires: python3-pytest (or upstream could be asked for a less "general purpose" dev extra, e.g. a test extra). https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_linters Also, removal of pytest-cov likely means going back to %pytest --override-ini addopts=. Side note: mypy is listed in build-system.requires in pyproject.toml (for mypyc support), but since PYTOKENS_USE_MYPYC=0 is set, it's a wasted build dependency. Probably not worth addressing, but good to document in a comment. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2497706 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202497706%23c6 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
