https://bugzilla.redhat.com/show_bug.cgi?id=2499516
--- Comment #3 from Neal Gompa <[email protected]> --- Initial spec review: > Source0: %{url}/archive/%{version}.tar.gz This should be "%{url}/archive/%{version}/libfm-%{version}.tar.gz" > BuildRequires: gcc-c++ You are missing BRs for make, autoconf, automake, and maybe autoconf-archive (if that's used for this)? > %{?ldconfig_scriptlets} This does nothing across all supported Fedora and RHEL releases. > %{_libdir}/%{name}.so.%{soname} > %{_libdir}/%{name}.so.%{soname}.* This can be simplified to "%{_libdir}/%{name}.so.%{soname}{,.*}" -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2499516 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202499516%23c3 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
