https://bugzilla.redhat.com/show_bug.cgi?id=2499516
UW_Linux <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #8 from UW_Linux <[email protected]> --- Informal/non-binding review: - The code built with `--with-extra-only`, including `fm-xml-file.c` and the installed public headers, is explicitly licensed under `LGPL-2.1-or-later`. Therefore, the current `License: GPL-2.0-or-later` does not match the packaged contents. In addition, the top-level `COPYING` contains the GPL-2.0 text and does not appear to be the applicable license text for `libfm-extra`. Upstream should ideally provide a separate LGPL-2.1 license file; the GPL `COPYING` file should not be installed as the `%license` file for this package. - The `-devel` package installs headers under `%{_includedir}/libfm-1.0`, but that directory is not owned by any package. It should probably include `%dir %{_includedir}/libfm-1.0`. - Since the built source is C, `BuildRequires: gcc` seems more appropriate than `gcc-c++`. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2499516 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202499516%23c8 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
