https://bugzilla.redhat.com/show_bug.cgi?id=2499516
Cristian Le <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] Flags| |needinfo?([email protected]) --- Comment #9 from Cristian Le <[email protected]> --- > The code built with `--with-extra-only`, including `fm-xml-file.c` and the > installed public headers, is explicitly licensed under `LGPL-2.1-or-later`. :+1: And it's not that that upstream *should* provide the license file, they *must* provide it. We can take the liberty here to add the license file in downstream until upstream accepts the patch to include it. Tip for @[email protected], run locally `fedora-review -b 2499516` and you will get the full license-review breakdown (the one mentioned in the review template). It may not catch all license texts and it often misinterprets license, but it can give you a good head start for checking if the project has differently license files. Common things you should manually verify are test data providence and pre-compiled binaries. Other 2 points, yes :+1:. The dir one is not that pressing if nothing else is expected to co-own the directory (don't remember if it would leave `%{_includedir}/libfm-1.0` folder upon uninstall though). Some extra review points: - One thing suspicious is why is `--disable-static` not sufficient and you have to do a `find $RPM_BUILD_ROOT -name '*.la'`? - Can you manually do `autoreconf` instead of the `autogen.sh`? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2499516 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202499516%23c9 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
