https://bugzilla.redhat.com/show_bug.cgi?id=2510687
Mike FABIAN <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?([email protected] | |m) | --- Comment #21 from Mike FABIAN <[email protected]> --- (In reply to Akira TAGOH from comment #20) > Please fix this as one of MUST items: > > [ ]: If the package is under multiple licenses, the licensing breakdown > must be documented in the spec. > > You don't need these lines in the spec file because of outdated: > > > ### third_party color-emoji code is in BSD license > > noto-emoji doesn't have any BSD licensed files > > > # In nototools source > > ## nototools code is in ASL 2.0 license > > ### third_party ucd code is in Unicode license I removed these lines > Other than that, just to make sure: > > [ ]: Changelog in prescribed format. > [ ]: Spec use %global instead of %define unless justified. > Note: %define requiring justification: %define autorelease(e:s:pb:n) > %{?-p:0.}%{lua: I think that is OK. > According to comment#6, I expect you don't have real changelogs and own > %autorelease macro in the spec file, right? Yes, the spec file contains: Version: 2.051 Release: %autorelease and at the bottom: %changelog %autochangelog rpm-autospec then replaces %autochangelog with the contents of the external `changelog` file (which contains the historical changelog until the switch to using rpm-autospec) and on top of that, newer changelog entries are added based on the git commit log. Currently they are not added yet, if I call `fedpkg --release rawhide srpm`, rpm-autospec just replaces %autochangelog with the contents of the `changelog` file. But as soon as I push to rawhide and do `fedpkg build`, the latest git log message will be added to the changelog automatically. SPEC URL: https://download.copr.fedorainfracloud.org/results/mfabian/google-noto-color-emoji-fonts/srpm-builds/10856602/google-noto-color-emoji-fonts.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/mfabian/google-noto-color-emoji-fonts/srpm-builds/10856602/google-noto-color-emoji-fonts-2.051-1.fc45.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2510687 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202510687%23c21 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
