https://bugzilla.redhat.com/show_bug.cgi?id=2328456
--- Comment #15 from Fabio Porcedda <[email protected]> --- (In reply to Michael Cronenworth from comment #12) > Issues addressed. > > Spec URL: https://michael.cronenworth.com/RPMS/node-gyp.spec > SRPM URL: https://michael.cronenworth.com/RPMS/node-gyp-13.0.1-1.fc46.src.rpm Hi, when node is not already installed on the system, rpmspec emits: sh: line 1: node: command not found because the command is executed while parsing the spec instead of during %prep. Also the association to the nodejs-xx version is static. For example, if the package is built with nodejs24 associated, but at runtime only nodejs22 is available because it's the only one installed: dnf install node-gyp nodejs22 node-gyp installs fine, but when executed it tries to use nodejs24, while only nodejs22 is available. I think the best solution is to detect at runtime which nodejs version should be used. The node-gyp-system-node-gyp.patch should be updated to do that. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2328456 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202328456%23c15 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
