https://bugzilla.redhat.com/show_bug.cgi?id=2443717
--- Comment #41 from Scott Talbert <[email protected]> --- (In reply to Tarulia from comment #40) > I'm not a reviewer so obviously I don't make the call, but I want to raise > my concerns about this here. > > (In reply to Scott Talbert from comment #39) > > Most wxWidgets applications have > > a way to specify the wx-config path when building, so I think this should > > work. Otherwise, it is usually not hard to patch. > > IMHO that's a risky assumption to make. I'm not sure how "Most" was > determined when we don't know every wxWidgets based application out there. Searching codesearch.debian.net and general wxWidgets packaging experience on Debian and Fedora over the past 10+ years. > This is a solution I mentioned in Comment 18, since that's how Arch does it. > But as I said there, in the case of Aegisub for example I can't find such an > option and the only reference to wx-config in the repo is for the Mac build: > https://github.com/TypesettingTools/Aegisub/blob/ > 1ee570d9b218b60523f8b3834e3b28b76bf9df5e/packages/meson.build#L14-L19 I did look into this briefly. It seems Aegisub uses Meson, which discovers wx-config itself. It appears you could override the wx-config location by providing a config file. > Besides that I don't think it's a good idea to introduce distro-specific > binary names that deviate from upstream docs. This means that application > upstreams and/or developers would need to patch their build system around it > (if even possible, see above), which is probably not going to come off > great. For Fedora packagers that's a non-issue because it stays in the > Fedora ecosystem, but putting that on upstreams and developers too is a > different problem. But in any event, I agree with you that having to potentially patch every application is not great. I think alternatives is the least bad approach, so I've reverted back to it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2443717 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202443717%23c41 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
