Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=800930 --- Comment #13 from Martin Erik Werner <martinerikwer...@gmail.com> 2012-03-08 19:42:06 EST --- (In reply to comment #12) > You need a %doc entry in the %files section of the main package. Read this: > http://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Subpackage_Licensing > Ah, right, but I will then need to duplicate most of the license info in the -data package since it shouldn't depend on the engine package, right? > In the license.txt upstream has been very clear about the source and the > content, your comments before your all license source is enough as long as you > make sure the sub-packages require the main package. If this is enough, I'd be happy to remove the all-licenses file, however, I get the impression that (paraphrasing license.txt) "There are a whole bunch of individual licenses (some custom-written), dig through the subfolders in order to find them" ..is not really good enough, or is it? Note that there are a few home-made licenses there as well, my comments in the spec file only cover those which have a known shortname in Fedora. > > And seriously, lose all of the references to debian for your patches unless > you > are referring to a specific bug report. The why is much more important than > the > where. Better yet, refer to upstreams response to said bug report (I > understand > the debian maintainer is upstream). Whatever is going to help maintain the > package longterm The Debian maintainer is me, who is semi-upstream (doc, etc.) as well. I discussed those changes only via IRC (with main RE devs), so I'm afraid there's no response-reference for them. I tried to add some my "why" in the patch comments, hope it is reasonable. I've also tweaked the patch file headers to be a bit more Fedora-centric spec URL: http://arand.fedorapeople.org/5/redeclipse.spec -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
