Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=800930 --- Comment #14 from Brendan Jones <[email protected]> 2012-03-09 03:52:02 EST --- Getting there! When you make changes to your spec its customary to bump the release number and annotate in the %changlog like so: * Wed Feb 29 2012 Martin Erik Werner <[email protected]> 1.2-3 - blah * Wed Feb 29 2012 Martin Erik Werner <[email protected]> 1.2-2 - blah Also keep you spec file column with under 72 for readability (except where its not feasible for scripts), I'd also suggest having separate lines for each of your BuildRequires And Its also customary to order your tags like so: %package -n blah1 %description -n blah1 %package -n blah2 %description -n blah2 You can also drop rm -rf %{buildroot} from your %install section Change %{_mandir}/man6/%{name}-server.6.gz to %{_mandir}/man6/%{name}-server.6.* to allow for changes in compression format in subsequent releases Have a look at http://fedoraproject.org/wiki/Packaging:Guidelines#Libexecdir. Move the executables to %_bindir if these executables are to be run directly by users and not via the main executable. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
