On Fri, May 20, 2016 at 01:08:14PM +0200, Niels de Vos wrote: > On Thu, May 19, 2016 at 08:57:30PM +0200, Emmanuel Dreyfus wrote: > > Niels de Vos <[email protected]> wrote: > > > > > But when you download the tarball, there should not be any need to run > > > ./autogen.sh. I'm not sure why this seems to be required, but it looks > > > like it: > > > > Yes, one should not run autotools on the released tarball. > > Even the following steps fail for me when running on Fedora 23: > > $ ./autogen.sh > $ ./configure > $ make distcheck > ... > configure: error: cannot run /bin/sh ../../config.sub > Makefile:795: recipe for target 'distcheck' failed > make: *** [distcheck] Error 1 > > It works on the release-3.7 branch, so something has broken this more > recently. I'll try to figure out what happened and will report back > later.
It seems we intentionally removed the config.sub (yay, git bisect!): 7023870b28b1eb87fb6eca2904c72e91fdcaf625 is the first bad commit commit 7023870b28b1eb87fb6eca2904c72e91fdcaf625 Author: Kaleb S. KEITHLEY <[email protected]> Date: Fri May 29 13:47:14 2015 -0400 build: outdated autotools helper config.* files in dist tarfile Our jenkins release task clones the source, runs ./autogen.sh (where config.{guess,sub} come from) and ./configure, before running `make dist` to product the release glusterfs-X.Y.Z.tar.gz. The config.{guess,sub} in the tar file come from the archaic autoconf in CentOS 6.3, which is what the glusterfs jenkins is running on. We should not be shipping the (arbitrary, old) config.{guess,sub} files from our jenkins machine. Change-Id: Ib7643ae2e54d0e25c95f4e93e5dffb22cbe11523 BUG: 1223937 Signed-off-by: Kaleb S. KEITHLEY <[email protected]> Reviewed-on: http://review.gluster.org/11009 Reviewed-by: Niels de Vos <[email protected]> Tested-by: Gluster Build System <[email protected]> :100644 100644 82175ee7ea9afa36b9270bf62aad7437d1db1129 1282c981d53f19eebc05dbeb1f39c2bca45fac5a M Makefile.am :100644 100644 1e5a8125ad4765498c55b96dc53d3693a6757b17 36add2caccd448dfb8a839a5a5483f1ba5c1e9a2 M glusterfs.spec.in bisect run success Patrick filed https://bugzilla.redhat.com/1223937 for this during the 3.7 timeframe. I'm tempted to add the need to run autoreconf in the release notes unless someone really wants the config.sub/guess files back (we'll need to update the tools on the buildserver, but I would consider that a good thing anyway). Niels
signature.asc
Description: PGP signature
_______________________________________________ packaging mailing list [email protected] http://www.gluster.org/mailman/listinfo/packaging
