Hi, that is good news for us that there is a patch available. Can you provide some direction as to how we go about applying the patch "multiline-trap-fix-on-2.2.patch"? We are currently running PacketFence 1.8.7.
Thanks, Kevin -----Original Message----- From: Olivier Bilodeau [mailto:[email protected]] Sent: August-18-11 4:29 PM To: [email protected] Cc: Kevin Manuel Subject: Re: [Packetfence-users] invalid traps for adapters of oui=64:31:50 Hi Kevin, You'll be happy to hear that I'm working on a fix for #1098[1] the stringified MAC Addresses. > The fix you provided me translates the mac address into: > 5c:5c:26:20:38:78:47. Two problems: > > 1) it is an invalid 14-char mac address because of the "\\" = 5c5c. No big > deal, I added a line to substitute all "\\" with "\" ... fixed that one > Good catch, this one is easy to fix. > 2) the ascii representation for new line (0a) is being interpreted as an > ascii space (20) in the provided fix, so it gives the wrong mac address: > > 5c:26:20:38:78:47 instead of > 5c:26:0a:38:78:47 > > Not sure how to code this one to interpret the new line from the snmptrap - > any suggestions? Turns out this was done for multiline trap support in the pfsetvlan daemon. I tried finding why it was done this way in our source control history and couldn't go as back as that (before the 1.7 days). As a side note: if anyone could point me torwards the previous SCM used by the project to see commit history I would really appreciate it. Back to the topic at hand: It was replacing the newline char with a space and concatenating the multiline trap into a single string. I fixed it by keeping the newline char and updating the global trap parser to handle embedded newline characters. Patch is attached. Now, I need to update all the trap parsers to handle both Hex-STRING and STRING formats. Nasty, nasty bug.. [1] http://www.packetfence.org/bugs/view.php?id=1098 -- Olivier Bilodeau [email protected] :: +1.514.447.4918 *115 :: www.inverse.ca Inverse inc. :: Leaders behind SOGo (www.sogo.nu) and PacketFence (www.packetfence.org) ------------------------------------------------------------------------------ All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity and more. Splunk takes this data and makes sense of it. Business sense. IT sense. Common sense. http://p.sf.net/sfu/splunk-d2dcopy1 _______________________________________________ Packetfence-users mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/packetfence-users
