On Tue, 25 Feb 2003, Marcus Ramberg wrote:

> It probably goes about the wrong way to do some stuff, but it works for
> me. It's somewhat untested besides that though, so I'd love to hear
> from anyone who's got comments. It's a bit unfinished, most
> notoriously, it's missing a test suite, but no real show stoppers that
> I see.

A couple things.

First, let Mason (and Class::Container) do more work for you.  Add this to
valid_params:

 par_static_directory_index => { type => ARRAYREF,
                                 default => [ qw( index.htm index.html ) ],
                               },

This will handle a directive called MasonParStaticDirectoryIndex for you.

I'm not sure why you add this parameter when you call
HTML::Mason::ComponentSource->new:

              extra => { comp_root => 'par' },

You'd have to provide your own HTML::Mason::Component class (like
HTML::Mason::Component::PARBased) for this to be useful.

Finally, I'm not sure this actually has all that much to do with PAR,
since you don't use it internally (just Archive::Zip).  Maybe you can
document the relationship, and how this might work with a Mason
application distributed as a par-ball.


-dave

/*=======================
House Absolute Consulting
www.houseabsolute.com
=======================*/

Reply via email to