Hi Eric,

Eric Wilhelm schrieb:
I was running the tests as my normal user, and it appears that I killed it as root, or else it didn't properly cleanup at some point. Seems like it should probably use File::Temp::tempdir(), or at least create the temp dir inside of the distribution tree.

Can't remove directory /tmp/pp_switch_tests/temp0 (Permission denied) at a
utomated_pp_test.pl line 6966
Can't remove directory /tmp/pp_switch_tests (Directory not empty) at autom
ated_pp_test.pl line 6966

I'm confident this would be a good idea. We had several inquiries about this (dead pp_switch_tests lying around, owned by root) in the past. If the folder was in the distribution directory, people might figure out that it's related to them running stuff as root more easily. And the mess will be cleaned up when the re-extract the module .tar.gz.

Malcolm wrote the automated_pp_test.pl. I haven't really read all of it. (It's a lot of code!) I don't know how much work it'll be. Perhaps a five line change perhaps several dozens across 7000 lines...

Takers welcome!

Steffen

Reply via email to