Re: pp tests should use File::Temp?

[Malcolm Nooning]

> If you want to submit a patch, please submit it as a "diff -u" or, if 
you don't have a diff utility, send me the whole, modified, file and 
I'll do a diff for myself. That way, I don't have to apply the changes 
by hand. (That can become very tedious...)

I used the Windows UnxUtils diff.
diff -u automated_pp_test.pl_orig automated_pp_test.pl > aa_diff
Now that the test directory is going to be under the 
distribution/install directory, the fully qualified path names - on my 
machine - have blank spaces in them.  The tests used to pass before 
because  File::Spec->tmpdir gives back the Windows short path name, 
which does not have blank spaces.  In any case, a number of sub tests 
required \" before and after fully qualified path names.


--------------paste contents of aa_diff
--- automated_pp_test.pl_orig    Fri Dec 01 09:08:42 2006
+++ automated_pp_test.pl    Wed Jan 24 12:39:38 2007
@@ -23,7 +23,7 @@
#
#
########################################################################
-our $VERSION = 0.16;
+our $VERSION = 0.17;
########################################################################
# Prior to each test
#   . Remove any possible files that could exist from a previous
@@ -271,7 +271,7 @@

    if ($ENV{PAR_TEMP} and $ENV{PAR_TEMP} =~ /(.+)/) {
        $par_temp = $1;
-        return;
+        return $par_temp;
    }

    foreach $path (
@@ -2457,7 +2457,7 @@
  print ("\n"); # To add a line after the above expected error messages.

  #.................................................................
-  $cmd = 'pp --lib  ' . "$foo_dir foo.pl";
+  $cmd = 'pp --lib  ' . "\"$foo_dir\" foo.pl";
  if (system("$cmd")) {
    $$message_ref = "\namsg180: sub $test_name_string cannot system 
$cmd\n";
    return (EXIT_FAILURE);
@@ -5994,7 +5994,7 @@
    return (EXIT_FAILURE);
  }
  #.................................................................
-  $cmd = "pp -o $hello_executable -a $orig_fqpn hello.pl";
+  $cmd = "pp -o $hello_executable -a \"$orig_fqpn\" hello.pl";

  if (system("$cmd")) {
    $$message_ref = "\namsg596: sub $test_name_string cannot system 
$cmd\n";
@@ -6088,7 +6088,7 @@
  }

  #.................................................................
-  $cmd = "pp -o $hello_executable -a $forward_fqpn hello.pl";
+  $cmd = "pp -o $hello_executable -a \"$forward_fqpn\" hello.pl";
  if (system("$cmd")) {
    $$message_ref = "\namsg602: sub $test_name_string cannot system 
$cmd\n";
    return (EXIT_FAILURE);
@@ -6667,8 +6667,8 @@
  }

  #.................................................................
-  $cmd = "pp -o $hello_executable -A $all_text_files_fqpn " .
-                                " -a $all_text_files_fqpn " .
+  $cmd = "pp -o $hello_executable -A \"$all_text_files_fqpn\" " .
+                                " -a \"$all_text_files_fqpn\" " .
                                " $hello_pl_file";
  print ("\namsg654: About to system $cmd\n") if $verbose;
  if (system("$cmd")) {
@@ -6773,8 +6773,8 @@

  #.................................................................
  $all_text_files_fqpn =~ s!\\!\/!g;
-  $cmd = "pp -o $hello_executable -A $all_text_files_fqpn " .
-                                " -a $all_text_files_fqpn " .
+  $cmd = "pp -o $hello_executable -A \"$all_text_files_fqpn\" " .
+                                " -a \"$all_text_files_fqpn\" " .
                                " $hello_pl_file";
  print ("\namsg672: About to system $cmd\n") if $verbose;
  if (system("$cmd")) {
@@ -6957,7 +6957,9 @@
$foo_executable = "foo$_out";
$bar_executable = "bar$_out";

-$startdir ||= File::Spec->catdir(File::Spec->tmpdir, 'pp_switch_tests');
+if ($startdir eq "") {
+  $startdir = File::Spec->catdir($orig_dir, 'pp_switch_tests');
+}
File::Path::rmtree([$startdir]) if -d $startdir;

# Clean up after us.
------------end paste