Christoph Otto wrote:
The ops_pct branch is ready to merge into trunk.
Thanks for a tremendous amount of work on this project.
But before we plan on world domination, we should figure out how to
respond to criticism ;-) . Specifically, the criticism raised by
t/codingstd/perlcritic.t in the attachment.
Now, it's probably the case that files like
compilers/opsc/src/Ops/Compiler.pm are coded correctly, and that the
standards imposed by perlcritic.t for Perl 5 files are inappropriate for
NQP files. If that's the case, then the standards must change or the
test file that implements them must exclude NQP files from its scope.
(I don't claim to know which way is better.)
Either way, we should figure out what we should do before merging.
Otherwise the manager for next Tuesday's release will be unable to get a
'make fulltest' to PASS.
Thank you very much.
kid51
t/codingstd/perlcritic.t ....... 1/650
# Failed test 'Test::Perl::Critic for
"/home/jimk/work/ops_pct/compilers/opsc/src/Ops/Compiler.pm"'
# at t/codingstd/perlcritic.t line 95.
#
# Perl::Critic found these violations in
"/home/jimk/work/ops_pct/compilers/opsc/src/Ops/Compiler.pm":
# Code before strictures are enabled at
/home/jimk/work/ops_pct/compilers/opsc/src/Ops/Compiler.pm line 5
# Code before warnings are enabled at
/home/jimk/work/ops_pct/compilers/opsc/src/Ops/Compiler.pm line 5
# Missing properly located perl coda for parrot source at
/home/jimk/work/ops_pct/compilers/opsc/src/Ops/Compiler.pm line 18
# Failed test 'Test::Perl::Critic for
"/home/jimk/work/ops_pct/compilers/opsc/src/Ops/Compiler/Actions.pm"'
# at t/codingstd/perlcritic.t line 95.
#
# Perl::Critic found these violations in
"/home/jimk/work/ops_pct/compilers/opsc/src/Ops/Compiler/Actions.pm":
# Code before strictures are enabled at
/home/jimk/work/ops_pct/compilers/opsc/src/Ops/Compiler/Actions.pm line 5
# Code before warnings are enabled at
/home/jimk/work/ops_pct/compilers/opsc/src/Ops/Compiler/Actions.pm line 5
# Missing properly located perl coda for parrot source at
/home/jimk/work/ops_pct/compilers/opsc/src/Ops/Compiler/Actions.pm line 213
# Failed test 'Test::Perl::Critic for
"/home/jimk/work/ops_pct/compilers/opsc/src/Ops/Compiler/Grammar.pm"'
# at t/codingstd/perlcritic.t line 95.
#
# Perl::Critic found these violations in
"/home/jimk/work/ops_pct/compilers/opsc/src/Ops/Compiler/Grammar.pm":
# Code before strictures are enabled at
/home/jimk/work/ops_pct/compilers/opsc/src/Ops/Compiler/Grammar.pm line 4
# Code before warnings are enabled at
/home/jimk/work/ops_pct/compilers/opsc/src/Ops/Compiler/Grammar.pm line 4
# Missing properly located perl coda for parrot source at
/home/jimk/work/ops_pct/compilers/opsc/src/Ops/Compiler/Grammar.pm line 8
t/codingstd/perlcritic.t ....... 5/650
# Failed test 'Test::Perl::Critic for
"/home/jimk/work/ops_pct/compilers/opsc/src/Ops/Emitter.pm"'
# at t/codingstd/perlcritic.t line 95.
#
# Perl::Critic found these violations in
"/home/jimk/work/ops_pct/compilers/opsc/src/Ops/Emitter.pm":
# Code before strictures are enabled at
/home/jimk/work/ops_pct/compilers/opsc/src/Ops/Emitter.pm line 5
# Code before warnings are enabled at
/home/jimk/work/ops_pct/compilers/opsc/src/Ops/Emitter.pm line 5
# Missing properly located perl coda for parrot source at
/home/jimk/work/ops_pct/compilers/opsc/src/Ops/Emitter.pm line 7
# Failed test 'Test::Perl::Critic for
"/home/jimk/work/ops_pct/compilers/opsc/src/Ops/File.pm"'
# at t/codingstd/perlcritic.t line 95.
#
# Perl::Critic found these violations in
"/home/jimk/work/ops_pct/compilers/opsc/src/Ops/File.pm":
# Flag comment 'XXX' found at
/home/jimk/work/ops_pct/compilers/opsc/src/Ops/File.pm line 5
# Missing properly located perl coda for parrot source at
/home/jimk/work/ops_pct/compilers/opsc/src/Ops/File.pm line 7
# Failed test 'Test::Perl::Critic for
"/home/jimk/work/ops_pct/compilers/opsc/src/Ops/Op.pm"'
# at t/codingstd/perlcritic.t line 95.
#
# Perl::Critic found these violations in
"/home/jimk/work/ops_pct/compilers/opsc/src/Ops/Op.pm":
# Missing properly located perl coda for parrot source at
/home/jimk/work/ops_pct/compilers/opsc/src/Ops/Op.pm line 5
t/codingstd/perlcritic.t ....... 8/650
# Failed test 'Test::Perl::Critic for
"/home/jimk/work/ops_pct/compilers/opsc/src/Ops/OpLib.pm"'
# at t/codingstd/perlcritic.t line 95.
#
# Perl::Critic found these violations in
"/home/jimk/work/ops_pct/compilers/opsc/src/Ops/OpLib.pm":
# Code before strictures are enabled at
/home/jimk/work/ops_pct/compilers/opsc/src/Ops/OpLib.pm line 4
# Code before warnings are enabled at
/home/jimk/work/ops_pct/compilers/opsc/src/Ops/OpLib.pm line 4
# Missing properly located perl coda for parrot source at
/home/jimk/work/ops_pct/compilers/opsc/src/Ops/OpLib.pm line 11
# Failed test 'Test::Perl::Critic for
"/home/jimk/work/ops_pct/compilers/opsc/src/Ops/Trans.pm"'
# at t/codingstd/perlcritic.t line 95.
#
# Perl::Critic found these violations in
"/home/jimk/work/ops_pct/compilers/opsc/src/Ops/Trans.pm":
# Code before strictures are enabled at
/home/jimk/work/ops_pct/compilers/opsc/src/Ops/Trans.pm line 5
# Code before warnings are enabled at
/home/jimk/work/ops_pct/compilers/opsc/src/Ops/Trans.pm line 5
# Missing properly located perl coda for parrot source at
/home/jimk/work/ops_pct/compilers/opsc/src/Ops/Trans.pm line 7
# Failed test 'Test::Perl::Critic for
"/home/jimk/work/ops_pct/compilers/opsc/src/Ops/Trans/C.pm"'
# at t/codingstd/perlcritic.t line 95.
#
# Perl::Critic found these violations in
"/home/jimk/work/ops_pct/compilers/opsc/src/Ops/Trans/C.pm":
# Code before strictures are enabled at
/home/jimk/work/ops_pct/compilers/opsc/src/Ops/Trans/C.pm line 5
# Code before warnings are enabled at
/home/jimk/work/ops_pct/compilers/opsc/src/Ops/Trans/C.pm line 5
# Missing properly located perl coda for parrot source at
/home/jimk/work/ops_pct/compilers/opsc/src/Ops/Trans/C.pm line 104
t/codingstd/perlcritic.t ....... 593/650
# Failed test 'Test::Perl::Critic for
"/home/jimk/work/ops_pct/tools/build/ops2c.pl"'
# at t/codingstd/perlcritic.t line 95.
#
# Perl::Critic found these violations in
"/home/jimk/work/ops_pct/tools/build/ops2c.pl":
# Code before strictures are enabled at
/home/jimk/work/ops_pct/tools/build/ops2c.pl line 5
# Code before warnings are enabled at
/home/jimk/work/ops_pct/tools/build/ops2c.pl line 5
t/codingstd/perlcritic.t ....... 649/650 # Looks like you failed 10 tests of
650.
t/codingstd/perlcritic.t ....... Dubious, test returned 10 (wstat 2560, 0xa00)
Failed 10/650 subtests
_______________________________________________
http://lists.parrot.org/mailman/listinfo/parrot-dev
