On Thu, May 13, 2010 at 11:04 PM, James E Keenan <[email protected]> wrote: > Christoph Otto wrote: >> >> The ops_pct branch is ready to merge into trunk. > > > Thanks for a tremendous amount of work on this project. > > But before we plan on world domination, we should figure out how to respond > to criticism ;-) . Specifically, the criticism raised by > t/codingstd/perlcritic.t in the attachment. > > Now, it's probably the case that files like > compilers/opsc/src/Ops/Compiler.pm are coded correctly, and that the > standards imposed by perlcritic.t for Perl 5 files are inappropriate for NQP > files. If that's the case, then the standards must change or the test file > that implements them must exclude NQP files from its scope. (I don't claim > to know which way is better.)
Yes. Perlcritic should only be run on Perl 5 code, not NQP or Perl 6 code; These should be excluded (probably in Parrot::Dist*) when finding "perl" files to process for testing. > Either way, we should figure out what we should do before merging. Otherwise > the manager for next Tuesday's release will be unable to get a 'make > fulltest' to PASS. > > Thank you very much. > kid51 > > _______________________________________________ > http://lists.parrot.org/mailman/listinfo/parrot-dev > > -- Will "Coke" Coleda _______________________________________________ http://lists.parrot.org/mailman/listinfo/parrot-dev
