#1105: [PATCH] change to a libjit based frame builder
----------------------+-----------------------------------------------------
Reporter: plobsing | Owner: jkeenan
Type: patch | Status: assigned
Priority: normal | Milestone:
Component: core | Version: trunk
Severity: medium | Keywords:
Lang: | Patch:
Platform: |
----------------------+-----------------------------------------------------
Comment(by jkeenan):
Replying to [comment:10 jkeenan]:
> Replying to [comment:9 plobsing]:
>
> I applied the three patches to the ''auto_libjit'' branch in the order
in which you posted them. I then ran: `perl Configure.pl --test
--configure_trace`. I got a failure in ''t/steps/auto/frames-01.t'',
which I am now trying to debug.
Reverting the last of your three patches -- which modified
''config/auto/frames.pm'' -- enabled ''t/steps/auto/frames-01.t'' to pass
once again. This is not entirely surprising to me, because I know that
lines 52-53 in that file were carefully chosen by bacek to reflect what we
knew about the framebuilding capabilities of different OS/platform
combinations. So I wrote tests in ''t/steps/auto/frames-01.t'' to reflect
that.
Now, the current formulation of ''config/auto/frames.pm'' is almost
certainly not the last word in detecting framebuilding. So your approach
may ultimately prove correct. I don't know enough myself to judge one way
or the other. And, of course, it may simply be the test file that needs
revising (but I'm skeptical that that's the only problem).
For better or worse, when I then tried `make`, I got the same build
failure as before. The output of my `make` log at r41891 differed from
that which I posted for r41837 only in the following:
{{{
$ diff -w 20091013.41837.auto_libjit.txt \
> 20091016.41891.auto_libjit.txt
337,339d336
< In file included from src/frame_builder_libjit.c:20:
< src/frame_builder_libjit.h:26:5: warning: "PARROT_HAS_LIBJIT" is not
defined
< src/frame_builder_libjit.c:22:5: warning: "PARROT_HAS_LIBJIT" is not
defined
}}}
So we've eliminated two warnings during `make`, but have not yet gotten
`make` to complete on a Linux/i386 box where libjit is not installed.
I committed to the branch the first two patches: see r41892. Thank you
for your continued efforts in this.
kid51
--
Ticket URL: <https://trac.parrot.org/parrot/ticket/1105#comment:12>
Parrot <https://trac.parrot.org/parrot/>
Parrot Development
_______________________________________________
parrot-tickets mailing list
[email protected]
http://lists.parrot.org/mailman/listinfo/parrot-tickets
