#1105: change to a libjit based frame builder
----------------------+-----------------------------------------------------
Reporter: plobsing | Owner: jkeenan
Type: patch | Status: assigned
Priority: normal | Milestone:
Component: core | Version: branch
Severity: medium | Keywords:
Lang: | Patch: applied
Platform: |
----------------------+-----------------------------------------------------
Comment(by jkeenan):
Replying to [comment:17 plobsing]:
> Replying to [comment:12 jkeenan]:
>
> > I committed to the branch the first two patches: see r41892.
>
> It appears that src/frame_builder_libjit.{h,c} got added to version
control and the manifest in this changeset. This is likely an error as
they are generated (in config/gen/libjit.pm).
Yes, I knew I was getting confused there. However, IIRC, the better
solution is to add them to ''MANIFEST.generated'' rather than
''MANIFEST.SKIP''. I'm assuming that Parrot and HLL developers
'''would''' want these available to them, hence inclusion in
''generated''. I also made sure they would get added to
''MANIFEST.configure.generated''.
Please see r41899.
Thank you very much,
kid51
--
Ticket URL: <https://trac.parrot.org/parrot/ticket/1105#comment:18>
Parrot <https://trac.parrot.org/parrot/>
Parrot Development
_______________________________________________
parrot-tickets mailing list
[email protected]
http://lists.parrot.org/mailman/listinfo/parrot-tickets
