#1785: src/pmc/oplib.pmc, src/pmc/resizeablestringarr.pmc: Deprecate duplicated
VTABLE functions in
-------------------------+--------------------------------------------------
Reporter: jkeenan | Owner:
Type: deprecation | Status: new
Priority: normal | Milestone:
Component: core | Version: 2.7.0
Severity: medium | Keywords:
Lang: | Patch:
Platform: |
-------------------------+--------------------------------------------------
In r48932, NotFound added a long overdue check for duplicated VTABLE
functions -- a check which, when applied, turned up these two duplicates:
{{{
Index: /trunk/src/pmc/oplib.pmc
===================================================================
--- /trunk/src/pmc/oplib.pmc (revision 48923)
+++ /trunk/src/pmc/oplib.pmc (revision 48932)
@@ -117,8 +117,4 @@
}
- VTABLE INTVAL get_integer() {
- return STATICSELF.elements();
- }
-
METHOD op_family(STRING *shortname)
{
Index: /trunk/src/pmc/resizablestringarray.pmc
===================================================================
--- /trunk/src/pmc/resizablestringarray.pmc (revision 46300)
+++ /trunk/src/pmc/resizablestringarray.pmc (revision 48932)
@@ -303,23 +303,4 @@
/*
-=item C<PMC *shift_pmc()>
-
-Removes and returns the first element in the array.
-
-=cut
-
-*/
-
- VTABLE PMC *shift_pmc() {
- STRING * const strval = SELF.shift_string();
- PMC * const value = Parrot_pmc_new(INTERP,
enum_class_String);
-
- VTABLE_set_string_native(INTERP, value, strval);
-
- return value;
- }
-
-/*
-
=item C<INTVAL shift_integer()>
}}}
However, pmichaud noted that Rakudo had inadvertently relied on the bug
and that, though he could easily correct the problem in Rakudo, this
should have been covered by a deprecation policy.
So I am reverting that commit, changing the `die` at line 74 of
lib/Parrot/Pmc2c/PMC.pm to a `warn`, and posting in ''DEPRECATED.pod''.
The next supported release is Oct 19 2010 and we can rip out the
duplicated functions immediately thereafter.
--
Ticket URL: <https://trac.parrot.org/parrot/ticket/1785>
Parrot <https://trac.parrot.org/parrot/>
Parrot Development
_______________________________________________
parrot-tickets mailing list
[email protected]
http://lists.parrot.org/mailman/listinfo/parrot-tickets
