#1785: src/pmc/oplib.pmc, src/pmc/resizeablestringarray.pmc: Deprecate
duplicated
VTABLE functions in
-------------------------+--------------------------------------------------
Reporter: jkeenan | Owner: jkeenan
Type: deprecation | Status: assigned
Priority: normal | Milestone: 3.0
Component: core | Version: 2.7.0
Severity: medium | Keywords:
Lang: | Patch:
Platform: |
-------------------------+--------------------------------------------------
Comment(by plobsing):
Replying to [comment:3 jkeenan]:
> Replying to [comment:2 NotFound]:
> > I can understand the reasons to want a deprecation for the error.
> >
> > But in the name of sanity, what is the reason to keep the duplicated
vtable functions in the PMC files? Just to hear me cry?
>
> The duplication of the vtable functions was erroneous, but, as discussed
on #parrot 2010-09-11, it was also the thing that needed to be put through
the deprecation cycle. I took on that responsibility; hence this ticket.
When touched, the code will emit warnings. After Oct 19, I'll change the
`warn` to a `die`, clear the item from ''DEPRECATION.pod'' and close the
ticket.
The duplicate vtable functions were being ignored and didn't occur in the
final PMC object code. It is therefore impossible that they were part of
any user visible functionality. By definition, they do not fall under the
deprecation policy.
What pmichaud argued falls under the deprecation policy is the behaviour
of pmc2c, changes to which had caused rakudo build failures.
The vtable changes were unfortunately caught up in the revert due to being
in the same commit. They should be reapplied ASAP because they add sanity
at no cost.
>
> Thank you very much.
>
> kid51
--
Ticket URL: <https://trac.parrot.org/parrot/ticket/1785#comment:5>
Parrot <https://trac.parrot.org/parrot/>
Parrot Development
_______________________________________________
parrot-tickets mailing list
[email protected]
http://lists.parrot.org/mailman/listinfo/parrot-tickets