#1785: src/pmc/oplib.pmc, src/pmc/resizeablestringarray.pmc: Deprecate
duplicated
VTABLE functions in
-------------------------+--------------------------------------------------
Reporter: jkeenan | Owner: jkeenan
Type: deprecation | Status: assigned
Priority: normal | Milestone: 3.0
Component: core | Version: 2.7.0
Severity: medium | Keywords:
Lang: | Patch:
Platform: |
-------------------------+--------------------------------------------------
Comment(by jonathan):
{{{
20:07 <@jnthn> As far as I understand, the detection is totally fine (in
fact,
good). However, pmichaud++ felt that dying rather than just
warning required a deprecation cycle.
20:08 <@jnthn> (I helped pm to track down and remove the duplicated
v-table
method we had somewhere in Rakudo. It's good to detect them
-
our duplication was a straightforward mistake.)
20:09 <@jnthn> oh wth
20:09 <@jnthn> The ticket is a complete mis-understanding.
20:09 <@jnthn> The duplicates serve no useful purpose and should be
tossed.
20:09 <@NotFound> Sigh... Again, the duplicated vtable functions don't get
compiled, they aren't put in the generated C file. Look
at
http://tapir2.ro.vutbr.cz/cover/cover-results/48955/c_cover/src-pmc-oplib-
pmc.html
20:09 <@jnthn> There's no way we could have depended on them.
20:10 <@jnthn> It was just a simple "die vs warn" issue.
20:10 <@jnthn> NotFound++ is right here.
}}}
So, we warn rather than die for now. But the dead code that was detected
can stay removed - it was dead code. :-)
--
Ticket URL: <https://trac.parrot.org/parrot/ticket/1785#comment:4>
Parrot <https://trac.parrot.org/parrot/>
Parrot Development
_______________________________________________
parrot-tickets mailing list
[email protected]
http://lists.parrot.org/mailman/listinfo/parrot-tickets
