> So maybe the name of this menu item is a "Macism"?

yep. see 
https://github.com/pure-data/pure-data/blob/master/tcl/apple_events.tcl#L58-L63

... for this reason, the "HTML Manual..." entry is only added to the
help menu for non-macOS or previous TCL versions:
https://github.com/pure-data/pure-data/blob/master/tcl/pd_menus.tcl#L361-L365

i'm not sure whether my new approach is good - so i'd certainly be
glad if more eyes could check this. i see 2 options now:
1. create only the help menu twice outside the loop (what Roman
tested): 
https://github.com/pure-data/pure-data/compare/master...ben-wes:pure-data:fix/tcl8.6help
2. create all these menus twice:
https://github.com/pure-data/pure-data/compare/master...ben-wes:pure-data:fix/tcl8.6help-2

after burning my fingers here, i'd prefer to let others decide. ;)

... and there's now unfortunately a need for a quick bugfix release
based on this mess, i'd be curious if other mac users can reproduce
what i reported in https://github.com/pure-data/pure-data/issues/2719

cheers,
ben


On Wed, Aug 6, 2025 at 3:09 PM Roman Haefeli <reduz...@gmail.com> wrote:
>
> On Wed, 2025-08-06 at 14:42 +0200, Miller Puckette via Pd-dev wrote:
> > OK, I'll wait until Roman (or anyone else) can verify this fixes it.
> > (Meanwhile I've hit at least one crasher bug when deleting
> > fields from [struct] objects (which sets off a chain of data
> > resizing and relocation) - so I'll probably have something to update
> > in a day or two as well.
>
> I applied this patch¹ to pd_menus.tcl and the menu entry "Pd Help"
> appeared again and opens the HTML manual in the browser. From what I
> can tell, this looks good on macOS Sequoia with this patch.
>
>
> Note: In Linux, the corresponding menu item is named "HTML Manual"
> which I find is more meaningful than just "Pd Help". Also, on the Mac,
> all menu items are localized except "Pd Help". I see in the code that
> macOS is handled differently. So maybe the name of this menu item is a
> "Macism"?
>
> Roman
>
>
> ¹
> https://github.com/pure-data/pure-data/commit/7ec024e7edff662e03a980995e9e196e0e0cf257
>  ---
> pd-dev@lists.iem.at - the Pd developers' mailinglist
> https://lists.iem.at/hyperkitty/list/pd-dev@lists.iem.at/message/6WIKU5MW4FP7MQ4TPKPMWOQY6XCIXMQR/

 ---
pd-dev@lists.iem.at - the Pd developers' mailinglist
https://lists.iem.at/hyperkitty/list/pd-dev@lists.iem.at/message/KBOZHMGWPRM6IQLS6TZXZADSQEL5VUOP/

Reply via email to