2014-05-04 8:13 GMT+09:00 Thomas Hruska <[email protected]>:
> I think I'm ready for a preliminary code review for PECL inclusion. I've
> been looking over the various documents on the account request page and I
> see a few potential issues, but I'd like feedback at this point for
> guidance/pointers/tips specific to actions I actually need to take vs.
> nice-to-haves before applying for a PECL account.
I've built your extension with php5.3 but it failed. You need to
define zval *tmp here.
```
#if PHP_VERSION_ID < 50399
zend_hash_copy(obj->std.properties, &ce->default_properties,
(copy_ctor_func_t)zval_add_ref, (void *)&tmp, sizeof(zval *));
```
`Sync_Mutex` class name would be `SyncMutex` better. please check User
Functions/Methods Naming Conventions #7.
http://git.php.net/?p=php-src.git;a=blob_plain;f=CODING_STANDARDS;hb=HEAD
Why do you choose multi licensing for php extension? Single license
would be simpler.
--
PECL development discussion Mailing List (http://pecl.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
