On Thu, Apr 08, 2010 at 11:22:05PM +0200, Stephane Eranian wrote: > On Thu, Apr 8, 2010 at 11:17 PM, Frederic Weisbecker <fweis...@gmail.com> > wrote: > > On Thu, Apr 08, 2010 at 11:14:15PM +0200, Stephane Eranian wrote: > >> On Thu, Apr 8, 2010 at 11:11 PM, Peter Zijlstra <pet...@infradead.org> > >> wrote: > >> > On Thu, 2010-04-08 at 23:08 +0200, Stephane Eranian wrote: > >> >> > >> >> Are you suggesting you add some padding the PEBS raw sample you > >> >> return as PERF_SAMPLE_RAW? Then you need to define what RAW > >> >> actually means? Seems here, it would mean more than what the > >> >> HW returns. > >> > > >> > Well, RAW doesn't mean anything much at all, its really a fugly pass > >> > some crap around thing. > >> > > >> > So yeah, adding padding seems just fine. > >> > > >> I would rather see size as u64. Who's using raw today anyway? > > > > > > The trace events. Hence the size of the size shouldn't be touched, it > > is an ABI now. > > Given your alignment constraints, it seems like it was a bad choice to pick > u32 for size to begin with.
Indeed, I'm not exactly sure how this is dealt since this is indeed u32 and the buffer requires to align to u64... ------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev _______________________________________________ perfmon2-devel mailing list perfmon2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/perfmon2-devel
