I took a quick look at the libpfm4.spec file in libpfm4. It probably should be 
named libpfm.spec instead. Ran rpmlint over the libpfm4.spec and got the 
following warning:

$ rpmlint libpfm4.spec
libpfm4.spec:45: W: rpm-buildroot-usage %build make 
install_prefix=$RPM_BUILD_ROOT%{_prefix}
libpfm4.spec:13: W: mixed-use-of-spaces-and-tabs (spaces: line 13, tab: line 4)
libpfm4.spec: W: invalid-url Source0: libpfm-4.1.0.tar.gz
0 packages and 1 specfiles checked; 0 errors, 3 warnings.


The spec file also needed a "buildrequires: swig".  The attached patch 
eliminates those rpmlint warnings and puts in the required build dependency.

-Will
--- libpfm4.spec.orig	2011-08-22 14:39:15.218642290 -0400
+++ libpfm.spec	2011-08-22 15:17:28.185629373 -0400
@@ -10,9 +10,10 @@
 Group:		System Environment/Libraries
 License:	MIT
 URL:		http://perfmon2.sourceforge.net/
-Source0:        %{name}-%{version}.tar.gz
-BuildRequires:  python-devel
-BuildRequires:  python-setuptools-devel
+Source0:	http://sourceforge.net/projects/perfmon2/files/libpfm4/%{name}-%{version}.tar.gz
+BuildRequires:	python-devel
+BuildRequires:	python-setuptools-devel
+BuildRequires:  swig
 BuildRoot:	%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
 
 %description
@@ -42,7 +43,7 @@
 %setup -q
 
 %build
-make install_prefix=$RPM_BUILD_ROOT%{_prefix}
+make
 
 %install
 rm -rf $RPM_BUILD_ROOT
@@ -55,8 +56,8 @@
 %clean
 rm -fr $RPM_BUILD_ROOT
 
-%post   -p /sbin/ldconfig
-%postun -p /sbin/ldconfig
+%post -p /sbin/ldconfig
+%postun	-p /sbin/ldconfig
 
 %files
 %defattr(644,root,root,755)
------------------------------------------------------------------------------
uberSVN's rich system and user administration capabilities and model 
configuration take the hassle out of deploying and managing Subversion and 
the tools developers use with it. Learn more about uberSVN and get a free 
download at:  http://p.sf.net/sfu/wandisco-dev2dev
_______________________________________________
perfmon2-devel mailing list
perfmon2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/perfmon2-devel

Reply via email to