On 08/24/2011 05:42 AM, stephane eranian wrote: > Patch applied. > > Why do you think we should rename that file?
Hi Stephane, Thanks. This is following the guidelines at: http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Spec_file_name The Name is libpfm. Thus, the guidelines suggest the spec file should be libpfm.spec. -Will > > On Mon, Aug 22, 2011 at 9:23 PM, William Cohen <wco...@redhat.com> wrote: >> I took a quick look at the libpfm4.spec file in libpfm4. It probably should >> be named libpfm.spec instead. Ran rpmlint over the libpfm4.spec and got the >> following warning: >> >> $ rpmlint libpfm4.spec >> libpfm4.spec:45: W: rpm-buildroot-usage %build make >> install_prefix=$RPM_BUILD_ROOT%{_prefix} >> libpfm4.spec:13: W: mixed-use-of-spaces-and-tabs (spaces: line 13, tab: line >> 4) >> libpfm4.spec: W: invalid-url Source0: libpfm-4.1.0.tar.gz >> 0 packages and 1 specfiles checked; 0 errors, 3 warnings. >> >> >> The spec file also needed a "buildrequires: swig". The attached patch >> eliminates those rpmlint warnings and puts in the required build dependency. >> >> -Will >> >> ------------------------------------------------------------------------------ >> uberSVN's rich system and user administration capabilities and model >> configuration take the hassle out of deploying and managing Subversion and >> the tools developers use with it. Learn more about uberSVN and get a free >> download at: http://p.sf.net/sfu/wandisco-dev2dev >> >> _______________________________________________ >> perfmon2-devel mailing list >> perfmon2-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/perfmon2-devel >> >> ------------------------------------------------------------------------------ EMC VNX: the world's simplest storage, starting under $10K The only unified storage solution that offers unified management Up to 160% more powerful than alternatives and 25% more efficient. Guaranteed. http://p.sf.net/sfu/emc-vnx-dev2dev _______________________________________________ perfmon2-devel mailing list perfmon2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/perfmon2-devel
