Hi Dave, Do you have any comments on the same?
Regards, Sanket Mehta Sr Software engineer Enterprisedb On Wed, Jun 17, 2015 at 5:52 PM, John Obaterspok <[email protected]> wrote: > Thanks, > > I can try to look at disabling when not in transaction mode + the short > cuts. > > Regarding the icons, toad for oracle uses a database icon which the arrows > point to/from. Perhaps we should add something *similar*? > > [image: Infogad bild 1] > > -- john > > 2015-06-17 13:44 GMT+02:00 Sanket Mehta <[email protected]>: > >> Hi John, >> >> I have applied the patch and below are my suggestions: >> >> 1. Rollback and commit icons should be disabled session is not in >> transaction mode >> 2. Rollback and Commit should also be included in Query menu and >> individual short cut should be assigned to them. >> >> Dave, >> >> Can we have any other icons for both the functionality as these icons >> looks odd to me. >> >> >> >> Regards, >> Sanket Mehta >> Sr Software engineer >> Enterprisedb >> >> On Tue, Jun 16, 2015 at 5:03 PM, Sanket Mehta < >> [email protected]> wrote: >> >>> Sure Dave. >>> >>> Regards, >>> Sanket Mehta >>> Sr Software engineer >>> Enterprisedb >>> >>> On Tue, Jun 16, 2015 at 4:55 PM, Dave Page <[email protected]> wrote: >>> >>>> Sanket, can you look at this please? >>>> >>>> Sent from my iPad >>>> >>>> > On 15 Jun 2015, at 16:33, John Obaterspok <[email protected]> >>>> wrote: >>>> > >>>> > Hello, >>>> > >>>> > With the newly added option to disable auto commit (hurray) I really >>>> missed commit/rollback toolbar buttons. Attached patch adds this. >>>> > >>>> > -- john >>>> > >>>> > <0001-Add-Commit-Rollback-toolbar-action.patch> >>>> > >>>> > -- >>>> > Sent via pgadmin-hackers mailing list ([email protected] >>>> ) >>>> > To make changes to your subscription: >>>> > http://www.postgresql.org/mailpref/pgadmin-hackers >>>> >>> >>> >> >
