On Fri, Jun 29, 2018 at 5:13 AM, David Rowley <david.row...@2ndquadrant.com> wrote: > On 20 June 2018 at 13:53, Michael Paquier <mich...@paquier.xyz> wrote: >> Clarify use of temporary tables within partition trees > > Thanks for committing this fix. > > I think slightly more should have been done. There's still some dead > code in expand_partitioned_rtentry that I think should be removed. > > The code won't cost much performance wise, but it may mislead someone > into thinking they can add some other condition there to skip > partitions. > > The attached removes it.
I'd rather keep an elog(ERROR) than completely remove the check. Also, for the record, I think the subject line of Michael's commit message was pretty unclear about what it was actually doing. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
