On 3 July 2018 at 10:16, Michael Paquier <mich...@paquier.xyz> wrote: > On Mon, Jul 02, 2018 at 02:07:37PM -0400, Robert Haas wrote: >> I'd rather keep an elog(ERROR) than completely remove the check. > > +1.
Attached >> Also, for the record, I think the subject line of Michael's commit >> message was pretty unclear about what it was actually doing. > > How would you formulate it? Perhaps the error message did not emphasize > enough on the fast that it actually blocked a behavior, say "Block mix > of temporary and permanent relations in partition trees" or such? For me, reading the subject line of the commit I'd have expected a doc change, or improved/new code comments. This is really more "Disallow mixed temp/permanent partitioned hierarchies". "Clarify" does not really involve a change of behaviour. It's an explanation of what the behaviour is. -- David Rowley http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services
remove_dead_code_from_expand_partitioned_rtentry_v2.patch
Description: Binary data
