Hi,
On 2014-03-12 15:52:58 +0000, Heikki Linnakangas wrote:
> Allow opclasses to provide tri-valued GIN consistent functions.
clang warns me about a mistake here:
In file included from
/home/andres/src/postgresql/src/backend/access/gin/ginxlog.c:16:
In file included from
/home/andres/src/postgresql/src/include/access/gin_private.h:14:
/home/andres/src/postgresql/src/include/access/gin.h:57:3: warning: no previous
extern declaration for
non-static variable 'GinLogicValueEnum'
[-Wmissing-variable-declarations]
} GinLogicValueEnum;
I think the GinLogicValueEnum is supposed to be an enum's name, not a
variable name, right?
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
diff --git a/src/include/access/gin.h b/src/include/access/gin.h
index 75a86c4..36a6c6b 100644
--- a/src/include/access/gin.h
+++ b/src/include/access/gin.h
@@ -48,13 +48,13 @@ typedef struct GinStatsData
} GinStatsData;
/* ginlogic.c */
-enum
+enum GinLogicValueEnum
{
GIN_FALSE = 0, /* item is present / matches */
GIN_TRUE = 1, /* item is not present / does not match */
GIN_MAYBE = 2 /* don't know if item is present / don't know if
* matches */
-} GinLogicValueEnum;
+};
typedef char GinLogicValue;
--
Sent via pgsql-committers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
