On Thu, Oct 22, 2026 at 09:28:31PM +0530, vignesh C wrote:
> On Fri, 16 Oct 2026 at 17:03, <[email protected]> wrote:
> >
> > The PG19 release-note entry about synchronizing sequence membership [1]
> > attributes that operation to REFRESH SEQUENCES. It should refer to
> > REFRESH PUBLICATION.
> >
> > REFRESH PUBLICATION adds and removes sequence entries in
> > pg_subscription_rel. REFRESH SEQUENCES instead resets existing sequence
> > entries to INIT for value resynchronization, without changing which
> > sequences are subscribed.
> >
> > This matches the ALTER SUBSCRIPTION reference [2] and the documentation
> > clarification committed as 19fbb47ef685 [3]. That commit did not update
> > release-19.sgml.
> >
> > The attached one-line patch changes the command name in that sentence.
> > It is based on REL_19_STABLE at a66ab9a9d382 and passes git apply --check.
> 
> Thanks for the patch, one suggestion, how about we mention something like:
> This is done by REFRESH PUBLICATION and by ADD PUBLICATION, DROP
> PUBLICATION, and SET PUBLICATION, which add newly published sequences
> to the subscription and remove dropped ones. REFRESH SEQUENCES does
> not change which sequences are subscribed.

Okay, I have applied the attached patch based on your instructions.  Let
me know if I need to change anything.

-- 
  Bruce Momjian  <[email protected]>        https://momjian.us
  EDB                                      https://enterprisedb.com

  Do not let urgent matters crowd out time for investment in the future.
diff --git a/doc/src/sgml/release-19.sgml b/doc/src/sgml/release-19.sgml
index 7d723995575..12704e568b1 100644
--- a/doc/src/sgml/release-19.sgml
+++ b/doc/src/sgml/release-19.sgml
@@ -1542,8 +1542,7 @@ Allow sequence values stored in subscribers to match the publisher (Vignesh C)
 </para>
 
 <para>
-This is enabled during <link linkend="sql-createsubscription"><command>CREATE SUBSCRIPTION</command></link>, <link linkend="sql-altersubscription"><command>ALTER SUBSCRIPTION ... REFRESH PUBLICATION</command></link>, and <link linkend="sql-altersubscription"><command>ALTER SUBSCRIPTION ... REFRESH SEQUENCES</command></link>.  The latter only updates values, not sequence
-existence.  Function <link linkend="func-pg-get-sequence-data"><function>pg_get_sequence_data()</function></link> allows inspection of sequence synchronization.
+This is enabled during <link linkend="sql-altersubscription"><command>ALTER SUBSCRIPTION ... [ADD|SET|REFRESH|DROP] PUBLICATION</command></link>.  Function <link linkend="func-pg-get-sequence-data"><function>pg_get_sequence_data()</function></link> allows inspection of sequence synchronization.
 </para>
 </listitem>
 

Reply via email to