On Tue, Oct 27, 2026 at 03:25:31PM +1100, Peter Smith wrote:
> I just saw this change.
>
> Personally, I find all those "This is enabled" bullets in this Logical
> Replication section to be potentially misleading because SUBSCRIPTION
> "enabled" or "disabled" [1] is an entirely different and unrelated
> concept to the sequence support.
>
> IMO all those points might be better expressed like
>
> "This occurs during ....", or
> "This happens when ...."
> "This is achieved by ..." or
> etc.
>
> e.g. choose anything that avoids the word "enabled"
I adjusted two places where "enable" was not the right word; applied
patch attached.
For these two sentences that you mentioned:
* This is enabled with the ALL SEQUENCES clause.
* This is enabled with the REFRESH SEQUENCES clause.
I realize "enabled" could be an overused concept in this text, but using
something like:
This occurs during the ALL SEQUENCES clause.
This happens when the ALL SEQUENCES clause.
This is achieved by the ALL SEQUENCES clause.
seem much less clear than the existing text.
--
Bruce Momjian <[email protected]> https://momjian.us
EDB https://enterprisedb.com
Do not let urgent matters crowd out time for investment in the future.
diff --git a/doc/src/sgml/release-19.sgml b/doc/src/sgml/release-19.sgml
index 094668ff953..275d727ceb4 100644
--- a/doc/src/sgml/release-19.sgml
+++ b/doc/src/sgml/release-19.sgml
@@ -599,7 +599,7 @@ Author: Tom Lane <[email protected]>
<listitem>
<para>
-Enable proper optimizer statistics for functions returning boolean values (Tom Lane)
+Add proper optimizer statistics for functions returning boolean values (Tom Lane)
<ulink url="&commit_baseurl;1eccb9315">§</ulink>
</para>
</listitem>
@@ -1570,7 +1570,7 @@ Allow sequence values stored in subscribers to match the publisher (Vignesh C)
</para>
<para>
-This is enabled during <link linkend="sql-altersubscription"><command>ALTER SUBSCRIPTION ... [ADD|SET|REFRESH|DROP] PUBLICATION</command></link>. Function <link linkend="func-pg-get-sequence-data"><function>pg_get_sequence_data()</function></link> allows inspection of sequence synchronization.
+This occurs during <link linkend="sql-altersubscription"><command>ALTER SUBSCRIPTION ... [ADD|SET|REFRESH|DROP] PUBLICATION</command></link>. Function <link linkend="func-pg-get-sequence-data"><function>pg_get_sequence_data()</function></link> allows inspection of sequence synchronization.
</para>
</listitem>
