On Tue, Oct 27, 2026 at 2:17 PM Bruce Momjian <[email protected]> wrote: > > On Thu, Oct 22, 2026 at 09:28:31PM +0530, vignesh C wrote: > > On Fri, 16 Oct 2026 at 17:03, <[email protected]> wrote: > > > > > > The PG19 release-note entry about synchronizing sequence membership [1] > > > attributes that operation to REFRESH SEQUENCES. It should refer to > > > REFRESH PUBLICATION. > > > > > > REFRESH PUBLICATION adds and removes sequence entries in > > > pg_subscription_rel. REFRESH SEQUENCES instead resets existing sequence > > > entries to INIT for value resynchronization, without changing which > > > sequences are subscribed. > > > > > > This matches the ALTER SUBSCRIPTION reference [2] and the documentation > > > clarification committed as 19fbb47ef685 [3]. That commit did not update > > > release-19.sgml. > > > > > > The attached one-line patch changes the command name in that sentence. > > > It is based on REL_19_STABLE at a66ab9a9d382 and passes git apply --check. > > > > Thanks for the patch, one suggestion, how about we mention something like: > > This is done by REFRESH PUBLICATION and by ADD PUBLICATION, DROP > > PUBLICATION, and SET PUBLICATION, which add newly published sequences > > to the subscription and remove dropped ones. REFRESH SEQUENCES does > > not change which sequences are subscribed. > > Okay, I have applied the attached patch based on your instructions. Let > me know if I need to change anything. >
Hi. I just saw this change. Personally, I find all those "This is enabled" bullets in this Logical Replication section to be potentially misleading because SUBSCRIPTION "enabled" or "disabled" [1] is an entirely different and unrelated concept to the sequence support. IMO all those points might be better expressed like "This occurs during ....", or "This happens when ...." "This is achieved by ..." or etc. e.g. choose anything that avoids the word "enabled" ------ Allow sequence values stored in subscribers to match the publisher (Vignesh C) § § § * This is enabled during CREATE SUBSCRIPTION, ALTER SUBSCRIPTION ... REFRESH PUBLICATION, and ALTER SUBSCRIPTION ... REFRESH SEQUENCES. The latter only updates values, not sequence existence. Function pg_get_sequence_data() allows inspection of sequence synchronization. Allow CREATE/ALTER PUBLICATION to publish all sequences (Vignesh C, Tomas Vondra) § * This is enabled with the ALL SEQUENCES clause. Allow ALTER SUBSCRIPTION on publications to synchronize the existence of sequences on subscribers to match the publisher (Vignesh C) § * This is enabled with the REFRESH SEQUENCES clause. ------ ====== [1] https://www.postgresql.org/docs/current/sql-createsubscription.html#SQL-CREATESUBSCRIPTION-PARAMS-WITH-ENABLED Kind Regards, Peter Smith. Fujitsu Australia
