On Fri, Feb 16, 2018 at 03:32:46PM -0500, Peter Eisentraut wrote: > Maybe that would work. > > We still need a way to configure whether we want to run tests that open > TCP/IP listen sockets.
For this an environment variable seems suited to me. Say if PG_TAP_ALLOW_INSECURE is set, then the tests said "insecure" are allowed to run. If the tests are tried to be run, then they are just skipped with a nice log message to tell you about it. The cool part about this design is that all the tests that are not part of check-world could be integrated in it. Most developers don't run regression tests on a shared resource. Let me think about a full-fledged patch first. Documentation also matters a lot. -- Michael
signature.asc
Description: PGP signature