On Tue, Feb 1, 2022 at 9:49 AM Fujii Masao <masao.fu...@oss.nttdata.com> wrote: > > My previous comment was confusing... Probably I understand why you tried to > put this information in checkpoint log message. But I was suggesting to put > that information at the end of log message instead of the beginning of it. > Because ordinary users would be less interested in this LSN information than > other ones like the number of buffers written.
Actually, there's no strong reason to put LSN info at the beginning of the message except that LSN/REDO LSN next to the checkpoint/restartpoint complete would make the users understand the LSN and REDO LSN belong to the checkpoint/restartpoint. Since this wasn't a strong reason, I agree to keep it at the end. Modified in v8. [1] 2022-02-01 04:34:17.657 UTC [3597073] LOG: checkpoint complete: wrote 21 buffers (0.1%); 0 WAL file(s) added, 0 removed, 0 recycled; write=0.004 s, sync=0.008 s, total=0.031 s; sync files=18, longest=0.006 s, average=0.001 s; distance=77 kB, estimate=77 kB; lsn=0/14D5AF0, redo lsn=0/14D5AB8 Regards, Bharath Rupireddy.
v8-0001-Add-checkpoint-and-redo-LSN-to-LogCheckpointEnd-l.patch
Description: Binary data
v8-0002-Change-location-to-lsn-in-pg_controldata.patch
Description: Binary data
