On 2023-01-15 Su 11:01, Tom Lane wrote: > Another thing I was just thinking about was not bothering to run > "diff" if the fixed dump strings are equal in-memory. You could > take that even further and not write out the fixed files at all, > but that seems like a bad idea for debuggability of the adjustment > subroutines. However, I don't see why we need to write an > empty diff file, nor parse it.
Yeah, that makes sense. > One other question before I continue --- do the adjustment > subroutines need to worry about Windows newlines in the strings? > It's not clear to me whether Perl will automatically make "\n" > in a pattern match "\r\n", or whether it's not a problem because > something upstream will have stripped \r's. > > I don't think we need to worry about them, but I will have a closer look. Those replacement lines are very difficult to read. I think use of extended regexes and some multi-part replacements would help. I'll have a go at that tomorrow. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com
