Hi, here is my review of the v18-0003 patch.
======
sgml/ref/alter_subscription.sgml
nitpick - some minor tweaks to the documentation text. I also added a link
back to the two_phase parameter. Please see the attached diffs file.
======
Kind Regards,
Peter Smith.
Fujitsu Australia
diff --git a/doc/src/sgml/ref/alter_subscription.sgml
b/doc/src/sgml/ref/alter_subscription.sgml
index e021f87..58db97f 100644
--- a/doc/src/sgml/ref/alter_subscription.sgml
+++ b/doc/src/sgml/ref/alter_subscription.sgml
@@ -256,14 +256,15 @@ ALTER SUBSCRIPTION <replaceable
class="parameter">name</replaceable> RENAME TO <
</para>
<para>
- The <literal>two_phase</literal> parameter can only be altered when the
- subscription is disabled. When altering the parameter from
<literal>true</literal>
+ The <link
linkend="sql-createsubscription-params-with-two-phase"><literal>two_phase</literal></link>
+ parameter can only be altered when the subscription is disabled.
+ When altering the parameter from <literal>true</literal>
to <literal>false</literal>, the backend process checks for any
incomplete
prepared transactions done by the logical replication worker (from when
<literal>two_phase</literal> parameter was still <literal>true</literal>)
- and, if any are found, this command is failed with an error. In this
- case, you can resolve prepared transactions on the publisher node or
- manually roll back them on the subscriber. After the altering from
+ and, if any are found, an error is reported. If this happens, you can
+ resolve prepared transactions on the publisher node or
+ manually roll back them on the subscriber, then try again. After the
altering from
<literal>true</literal> to <literal>false</literal>, the publisher will
replicate transactions again when they are committed.
</para>
