Hi Kuroda-San, here are some review comment for patch v19-00001
======
doc/src/sgml/ref/alter_subscription.sgml
The previous patches have common failover/two_phase code checking for
"Do not allow changing the option if the subscription is enabled", but
it seems the docs were mentioning that only for "two_phase" and not
for "failover".
I'm not 100% sure if mentioning about disabled was necessary, but
certainly it should be all-or-nothing, not just saying it for one of
the parameters. Anyway, I chose to add the missing info. Please see
the attached nitpicks diff.
======
Kind Regards,
Peter Smith.
Fujitsu Australia.
diff --git a/doc/src/sgml/ref/alter_subscription.sgml
b/doc/src/sgml/ref/alter_subscription.sgml
index 58db97f..e0ce83a 100644
--- a/doc/src/sgml/ref/alter_subscription.sgml
+++ b/doc/src/sgml/ref/alter_subscription.sgml
@@ -256,10 +256,15 @@ ALTER SUBSCRIPTION <replaceable
class="parameter">name</replaceable> RENAME TO <
</para>
<para>
- The <link
linkend="sql-createsubscription-params-with-two-phase"><literal>two_phase</literal></link>
- parameter can only be altered when the subscription is disabled.
- When altering the parameter from <literal>true</literal>
- to <literal>false</literal>, the backend process checks for any
incomplete
+ The <link
linkend="sql-createsubscription-params-with-failover"><literal>failover</literal></link>
+ and <link
linkend="sql-createsubscription-params-with-two-phase"><literal>two_phase</literal></link>
+ parameters can only be altered when the subscription is disabled.
+ </para>
+
+ <para>
+ When altering <link
linkend="sql-createsubscription-params-with-two-phase"><literal>two_phase</literal></link>
+ from <literal>true</literal> to <literal>false</literal>,
+ the backend process checks for any incomplete
prepared transactions done by the logical replication worker (from when
<literal>two_phase</literal> parameter was still <literal>true</literal>)
and, if any are found, an error is reported. If this happens, you can
