On Thu, Jul 18, 2024 at 7:40 AM Hayato Kuroda (Fujitsu) <kuroda.hay...@fujitsu.com> wrote: > > Regarding the CheckAlterSubOption(), the ordering is still preserved > because I preferred to keep some specs. But I can agree that yours > make codes simpler. >
It is better to simplify the code in this case. I have taken care of this in the attached. > BTW, I started to think patches can be merged in future versions because > they must be included at once and codes are not so long. Thought? > I agree and have done that in the attached. I have made some additional changes: (a) removed the unrelated change of two_phase in protocol.sgml, (b) tried to make the two_phase change before failover option wherever it makes sense to keep the code consistent, (c) changed/added comments and doc changes at various places. I'll continue my review and testing of the patch but I thought of sharing what I have done till now. -- With Regards, Amit Kapila.
v21-0001-Allow-altering-of-two_phase-option-of-a-SUBSCRIP.patch
Description: Binary data
