On Tue, Jul 23, 2024 at 9:23 AM Peter Smith <smithpb2...@gmail.com> wrote: > > On Fri, Jul 19, 2024 at 4:01 PM Shlok Kyal <shlok.kyal....@gmail.com> wrote: > > > > On Thu, 18 Jul 2024 at 13:55, Peter Smith <smithpb2...@gmail.com> wrote: > > > > > > Hi, here are some review comments for v19-0002 > > > ====== > > > src/test/subscription/t/004_sync.pl > > > > > > 1. > > > This new test is not related to generated columns. IIRC, this is just > > > some test that we discovered missing during review of this thread. As > > > such, I think this change can be posted/patched separately from this > > > thread. > > > > > I have removed the test for this thread. > > > > I have also addressed the remaining comments for v19-0002 patch. > > Hi, I have no more review comments for patch v20-0002 at this time. > > I saw that the above test was removed from this thread as suggested, > but I could not find that any new thread was started to propose this > valuable missing test. >
I still did not find any new thread for adding the missing test case, so I started one myself [1]. ====== [1] https://www.postgresql.org/message-id/CAHut+PtX8P0EGhsk9p=hqguhrzxecszanxsmkovyilx-ejd...@mail.gmail.com Kind Regards, Peter Smith. Fujitsu Australia
